Merge pull request #120 from anthonyprintup/new-lines-fix

Trim additional newline characters at the end of CMakeLists.txt
main
Duncan Ogilvie 8 months ago committed by GitHub
commit 2202aa8173
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1378,10 +1378,19 @@ void generate_cmake(const char *path, const parser::Project *parent_project) {
} }
} }
// Fetch the generated CMakeLists.txt output from the stringstream buffer
auto generated_cmake = ss.str();
// Make sure the file ends in a single newline
while (!generated_cmake.empty() && std::isspace(generated_cmake.back())) {
generated_cmake.pop_back();
}
generated_cmake += '\n';
// Generate CMakeLists.txt // Generate CMakeLists.txt
auto list_path = fs::path(path) / "CMakeLists.txt"; auto list_path = fs::path(path) / "CMakeLists.txt";
auto should_regenerate = [&list_path, &ss]() { auto should_regenerate = [&list_path, &generated_cmake]() {
if (!fs::exists(list_path)) if (!fs::exists(list_path))
return true; return true;
@ -1391,11 +1400,11 @@ void generate_cmake(const char *path, const parser::Project *parent_project) {
} }
std::string data((std::istreambuf_iterator<char>(ifs)), std::istreambuf_iterator<char>()); std::string data((std::istreambuf_iterator<char>(ifs)), std::istreambuf_iterator<char>());
return data != ss.str(); return data != generated_cmake;
}(); }();
if (should_regenerate) { if (should_regenerate) {
create_file(list_path, ss.str()); create_file(list_path, generated_cmake);
} }
auto generate_subdir = [path, &project](const fs::path &sub) { auto generate_subdir = [path, &project](const fs::path &sub) {

@ -109,4 +109,3 @@ add_test(
"$<TARGET_FILE:cmkr>" "$<TARGET_FILE:cmkr>"
build build
) )

Loading…
Cancel
Save